Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate v0.3.7 alpha #57

Merged
merged 64 commits into from
Oct 9, 2024
Merged

Release candidate v0.3.7 alpha #57

merged 64 commits into from
Oct 9, 2024

Conversation

benjaminbollen
Copy link
Member

@benjaminbollen benjaminbollen commented Oct 7, 2024

Changelog

  1. code: V0.3.7 patch01 personal mint reentrancy #47
    context: personalMint() reentrancy attack hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#8

  2. code: (hub): on update v1 status, never reduce lastMintTime to avoid resett… #48
    context: User can reset the INDEFINITE_FUTURE mintTime hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#1

  3. code: (Hub, InflatCRC, Circles): tidy up unused variable, docstring, comment #49
    context: Issuance Calculation Incosinstency hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#3

  4. code: V0.3.7 patch04 deploy erc20 only for humans and orgs #50
    context: lack of check in ensureERC20 compare to wrap Function  hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#25

  5. code: V0.3.7 patch05 missing hour when minting exactly on the hour #51
    context: Incorrect Calculation of Remaining Hours in Day B in _calculateIssuance Function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#39

  6. code: (hub): correct trivial error in error in _matchNettedFlows #52
    context: Incorrect error revert in _matchNettedFlows() function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#41

  7. code: (hub, circles): suppress group mint's acceptance call if along a path… #53
    context: Inefficient Token Transfer Handling for Middle Vertices Groups in _effectPathTransfers Function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#46

  8. code: (demurrage): small possible gas optimisation #54
    context: else-block is not needed hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#44

  9. code: (migration): require migration amount to be greater than zero #55
    context: Zero-Amount Vulnerability in migrate Function Allows Unauthorized Migration hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#50

  10. code: (InflationaryOperator): initialise inflationDayZero from Hub #56
    context: in InflationaryOperator this should also have been initialised

  11. code: V0.3.7 patch11 improve events in standard treasury #58
    context: wrong mint emission in treasury contract hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#85

  12. code: (errors): rename variable in error for correctness #59
    context: Incorrect error revert in operateFlowMatrix() function hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#106

  13. code: (nameRegistry): check short name is not zero #60
    context: It is possible for shortName to be calculated as the 0 bytes, breaking certain invariants  hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#113

  14. code: (nameRegistry): remove restriction only registered address can regist… #61
    context: request from internal for v2 invitation flow to store metadata, v1 (and v3+) compatibility, and error on blocking view functions

  15. code: V0.3.7 patch15 improve hourly check #64
    context: Unnecessary Hourly Check in _calculateIssuance Function Prevents Users from Receiving Rewards hats-finance/Circles-0x6ca9ca24d78af44582951825bef9eadcb210e5cf#114

  16. code: (StandardTreasury): correct data passed to be user data to policy for… #62
    context: for group redeem the data passed should also have been UserData; our base policy would not have worked with this

  17. code: V0.3.7 patch17 reduce compile size by compressing errors #65
    context: reducing code compile size with compressing errors and collapsing requirements together mostly

  18. code: V0.3.7 patch18 reintroduce events #66
    context: with spare room, re-introduce some valuable events

  19. code: (nameRegistry): register hub as Circles (CRC) in name registry #67
    context: register hub address as name "Circles", symbol "CRC" in NameRegistry in constructor

@cducrest
Copy link

cducrest commented Oct 9, 2024

Looks good to me.

@benjaminbollen benjaminbollen merged commit f6f81b9 into develop Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants